fix: Course filter adds duplicate values #275
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 96.04% 96.36% +0.32%
==========================================
Files 194 194
Lines 1844 1843 -1
Branches 322 326 +4
==========================================
+ Hits 1771 1776 +5
+ Misses 68 62 -6
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
Thanks for this! Looks good to me but I suppose there are a few conflicts that must be resolved. If you could fix those up I can make sure this gets merged. :) |
|
@hinakhadim I didn't properly tag you in my first comment (sorry!). I approved the changes but there are some conflicts that need to be resolved. Could you rebase your changes and fix any conflicts? I'll ensure we merge it right after it passes all checks. Thanks! |
hinakhadim
force-pushed
the
fix/course-filter
branch
from
83af928 to
24cc560
Compare
|
Thanks @justinhynes for your co-operation. I've resolved the conflicts and feel free to test it. |
The
@edx/paragonhas a bug in the version20.44.0which is currently being used infrontend-app-learner-dashboardas mentioned in #260 . The bug is that when clicking on any filter option, it is added twice which also resulted in unexpected behaviour of remove filter option. On Debugging, it is found that the bug is existed in the@edx/paragon(clicking on checkbox resulted in duplicate calls ofonChange). This bug has been fixed in two versions of@edx/paragonthat arev20.46.3andv21.5.3. More details can be found here: Link to @edx/paragon PRThis PR is updating the
@edx/paragonversion tov20.46.3which will closed the #260 .